feat: migrate from autorest/adal to azidentity
#1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramase
force-pushed
the
azidentity
branch
4 times, most recently
from
9ebca13
to
ec56abc
Compare
|
This PR is stale because it has been open 14 days with no activity. Please comment or this will be closed in 7 days. |
aramase
force-pushed
the
azidentity
branch
2 times, most recently
from
f8c31e5
to
ca90e74
Compare
Codecov Report
@@ Coverage Diff @@
## master #1028 +/- ##
==========================================
- Coverage 59.16% 56.34% -2.82%
==========================================
Files 10 10
Lines 1097 1072 -25
==========================================
- Hits 649 604 -45
- Misses 413 443 +30
+ Partials 35 25 -10 |
|
/azp run pr-e2e-azure |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
|
/azp run pr-e2e-azure |
|
Azure Pipelines successfully started running 1 pipeline(s). |
aramase
commented
Feb 6, 2023
There was a problem hiding this comment.
Windows tests are failing because the image we use for test pods is broken on windows
Warning FailedMount 26s kubelet MountVolume.SetUp failed for volume "secrets-store-inline" : rpc error: code = Unknown desc = failed to mount secrets store objects for pod key-9zhtd/busybox-secrets-store-inline-crd, err: error connecting to provider "azure": provider not found: provider "azure"
Normal Pulling 5s kubelet Pulling image "k8s.gcr.io/e2e-test-images/busybox:1.29"
Warning Failed 4s kubelet Failed to pull image "k8s.gcr.io/e2e-test-images/busybox:1.29": rpc error: code = NotFound desc = failed to pull and unpack image "k8s.gcr.io/e2e-test-images/busybox:1.29": no match for platform in manifest: not found
i'll debug this in a bit and update the image to a working one in a different PR!
#1079 should resolve this! |
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
|
/azp run pr-e2e-azure |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nilekhc
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com
Reason for Change:
azidentityas adal is deprecated.Requirements
Issue Fixed:
fixes #996
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Special Notes for Reviewers: