Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip WriteCertAndKeyInSeparateFiles tests in arc #1034

Merged
merged 1 commit into from Dec 7, 2022

Conversation

aramase
Copy link
Member

@aramase aramase commented Dec 7, 2022

Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com

Reason for Change:

  • Arc extension doesn't support this new helm flag, so disabling this test for the extension.

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Does this change contain code from or inspired by another project?

  • Yes
  • No

If "Yes," did you notify that project's maintainers and provide attribution?

Special Notes for Reviewers:
We should think about enabling this flag for arc extension if required in the future as default is false.

@aramase
Copy link
Member Author

aramase commented Dec 7, 2022

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase
Copy link
Member Author

aramase commented Dec 7, 2022

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aramase aramase marked this pull request as ready for review December 7, 2022 20:18
@aramase aramase requested a review from nilekhc as a code owner December 7, 2022 20:18
@aramase aramase enabled auto-merge (squash) December 7, 2022 20:18
@aramase aramase merged commit 3c60da7 into Azure:master Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants