Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update helm install logic for upgrade tests #1041

Merged
merged 1 commit into from Dec 15, 2022

Conversation

aramase
Copy link
Member

@aramase aramase commented Dec 14, 2022

Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com

Reason for Change:

  • update helm install logic for upgrade tests
    • we can't use charts/csi-secrets-store-provider-azure when cutting releases because the image will be latest and not yet available. So switching the logic to use the official helm chart repo to install the latest available provider.

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Does this change contain code from or inspired by another project?

  • Yes
  • No

If "Yes," did you notify that project's maintainers and provide attribution?

Special Notes for Reviewers:

@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2022

Codecov Report

Merging #1041 (fc28247) into master (d5c8c90) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1041   +/-   ##
=======================================
  Coverage   59.16%   59.16%           
=======================================
  Files          10       10           
  Lines        1097     1097           
=======================================
  Hits          649      649           
  Misses        413      413           
  Partials       35       35           

@aramase
Copy link
Member Author

aramase commented Dec 14, 2022

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aramase aramase marked this pull request as ready for review December 14, 2022 07:33
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase enabled auto-merge (squash) December 15, 2022 03:40
@aramase aramase merged commit de6c0c5 into Azure:master Dec 15, 2022
@aramase aramase deleted the upgrade-test-helm-update branch December 15, 2022 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants