docs: Update documentation to reflect change from 'tenantId' to 'tenantID' #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reetasingh
added a commit
to reetasingh/secrets-store-csi-driver-provider-azure
that referenced
this pull request
Jan 11, 2023
aramase
requested changes
Jan 12, 2023
There was a problem hiding this comment.
Thanks for the PR @reetasingh!
There are few other places in the website directory this needs to be updated.
grep -rnw website/ -e 'tenantId'
website/content/en/configurations/custom-environments.md:58:If the target cloud's identity provider system is [AD FS][adfs] (instead of Azure AD), then the `tenantId` property in `SecretProviderClass` should be set to `"adfs"`.
website/content/en/configurations/custom-environments.md:65: tenantId: "adfs"
website/content/en/configurations/identity-access-modes/pod-identity-mode.md:36: tenantId: "tid" # the tenant ID of the KeyVault
website/content/en/configurations/identity-access-modes/user-assigned-msi-mode.md:38: tenantId: "tid" # the tenant ID of the KeyVault
website/content/en/configurations/identity-access-modes/service-principal-mode.md:36: tenantId: "tid" # the tenant ID of the KeyVault
website/content/en/configurations/identity-access-modes/workload-identity-mode.md:37: tenantId: "tid" # the tenant ID of the KeyVault
website/content/en/configurations/identity-access-modes/system-assigned-msi-mode.md:38: tenantId: "tid" # the tenant ID of the KeyVault
website/content/en/configurations/sync-multiple-versions.md:38: tenantId: "tid" # the tenant ID of the KeyVault
website/content/en/configurations/ingress-tls.md:72:* Set the `tenantId` and `keyvaultName`
website/content/en/configurations/ingress-tls.md:105: tenantId: $TENANT_ID # the tenant ID of the KeyVault
website/content/en/configurations/sync-with-k8s-secrets.md:44: tenantId: "tid" # the tenant ID of the KeyVault
website/content/en/configurations/set-env-var.md:44: tenantId: "tid" # the tenant ID of the KeyVault
website/content/en/demos/standard-walkthrough/_index.md:106: tenantId: "${TENANT_ID}"
website/content/en/getting-started/usage/_index.md:62: tenantId: "tid" # the tenant ID of the KeyVault
website/content/en/getting-started/usage/_index.md:85: | tenantId | yes | tenant ID containing the Key Vault instance. Should be set to `"adfs"` for [Azure Stack Hub clouds](../../configurations/custom-environments) using the AD FS identity provider system 
aramase
changed the title
|
@aramase fixed it |
Codecov Report
@@ Coverage Diff @@
## master #1057 +/- ##
=======================================
Coverage 59.16% 59.16%
=======================================
Files 10 10
Lines 1097 1097
=======================================
Hits 649 649
Misses 413 413
Partials 35 35 |
aramase
approved these changes
Jan 20, 2023
|
/azp run pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
tenantId param will be deprecated in favor of tenantID. update the documentation to reflect change from 'tenantId' to 'tenantID
Requirements
Issue Fixed:
fixes #1027
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Special Notes for Reviewers: