Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: pin k8s-extension version to 1.3.5 #1077

Merged
merged 1 commit into from Feb 3, 2023

Conversation

aramase
Copy link
Member

@aramase aramase commented Feb 3, 2023

Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com

Reason for Change:

  • The PR gate and nightly test runs for arc are failing due to issues with the latest k8s-extension. Pinning to a specific version of the extension that works!

Test run with pinning the version: https://dev.azure.com/AzureContainerUpstream/Secrets%20Store%20CSI%20Driver%20Provider%20Azure/_build/results?buildId=77487&view=results

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

fixes #1076

Does this change contain code from or inspired by another project?

  • Yes
  • No

If "Yes," did you notify that project's maintainers and provide attribution?

Special Notes for Reviewers:

@aramase
Copy link
Member Author

aramase commented Feb 3, 2023

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2023

Codecov Report

Merging #1077 (ea51420) into master (a9fd76f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1077   +/-   ##
=======================================
  Coverage   59.16%   59.16%           
=======================================
  Files          10       10           
  Lines        1097     1097           
=======================================
  Hits          649      649           
  Misses        413      413           
  Partials       35       35           

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase marked this pull request as ready for review February 3, 2023 23:26
@aramase aramase requested a review from nilekhc as a code owner February 3, 2023 23:26
@aramase aramase enabled auto-merge (squash) February 3, 2023 23:27
@aramase aramase merged commit d9402ab into Azure:master Feb 3, 2023
@aramase aramase deleted the pin-k8s-extension-version branch February 4, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e2e_arc_kind failing in nightly runs
3 participants