Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adds links and support statement for managed offerings #1094

Merged
merged 1 commit into from Mar 15, 2023

Conversation

nilekhc
Copy link
Contributor

@nilekhc nilekhc commented Mar 14, 2023

Reason for Change:

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:
Fixes #1095

Does this change contain code from or inspired by another project?

  • Yes
  • No

If "Yes," did you notify that project's maintainers and provide attribution?

Special Notes for Reviewers:

@nilekhc nilekhc requested a review from aramase as a code owner March 14, 2023 23:38
@nilekhc
Copy link
Contributor Author

nilekhc commented Mar 14, 2023

cc @ritazh

@@ -43,3 +43,5 @@ This project has adopted the [Microsoft Open Source Code of Conduct](https://ope
## Support

Azure Key Vault Provider for Secrets Store CSI Driver is an open source project that is [**not** covered by the Microsoft Azure support policy](https://support.microsoft.com/en-us/help/2941892/support-for-linux-and-open-source-technology-in-azure). [Please search open issues here](https://github.com/Azure/secrets-store-csi-driver-provider-azure/issues), and if your issue isn't already represented please [open a new one](https://github.com/Azure/secrets-store-csi-driver-provider-azure/issues/new/choose). The project maintainers will respond to the best of their abilities.

However, [Arc extension](https://learn.microsoft.com/en-us/azure/azure-arc/kubernetes/tutorial-akv-secrets-provider) and [AKS addon](https://learn.microsoft.com/en-us/azure/aks/csi-secrets-store-driver) for _Azure Key Vault Provider for Secrets Store CSI Driver_ are managed offerings and supported by Microsoft Azure support policy.
Copy link
Member

@ritazh ritazh Mar 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I missed it but I could not find a link to the AKS addon or Arc extension in this project's website or readme. Can we update the landing page so it is very easy to discover them?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the main Readme. Please let me know if there is a better way to surface this here.

I have also added it to the main landing page of the website. https://deploy-preview-1094--secrets-store-csi-driver-provider-azure.netlify.app/#managed-add-ons

Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1094 (1357572) into master (3c68b0e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1094   +/-   ##
=======================================
  Coverage   56.34%   56.34%           
=======================================
  Files          10       10           
  Lines        1072     1072           
=======================================
  Hits          604      604           
  Misses        443      443           
  Partials       25       25           

@nilekhc nilekhc requested review from aramase and ritazh March 15, 2023 21:26
Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nilekhc nilekhc merged commit 4e49d86 into Azure:master Mar 15, 2023
9 checks passed
@nilekhc nilekhc deleted the support-doc-update branch March 15, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update support to clarify aks addon and arc extensions are supported
5 participants