Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updates msi-adapter image #1103

Merged
merged 1 commit into from Mar 28, 2023
Merged

Conversation

nilekhc
Copy link
Contributor

@nilekhc nilekhc commented Mar 27, 2023

Reason for Change:

Updates MSI Adapter to address vulnerability fixes.

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Does this change contain code from or inspired by another project?

  • Yes
  • No

If "Yes," did you notify that project's maintainers and provide attribution?

Special Notes for Reviewers:

@nilekhc nilekhc marked this pull request as ready for review March 27, 2023 23:36
@nilekhc nilekhc requested a review from aramase as a code owner March 27, 2023 23:36
@nilekhc
Copy link
Contributor Author

nilekhc commented Mar 27, 2023

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nilekhc nilekhc enabled auto-merge (squash) March 27, 2023 23:37
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@e36fd57). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1103   +/-   ##
=========================================
  Coverage          ?   56.34%           
=========================================
  Files             ?       10           
  Lines             ?     1072           
  Branches          ?        0           
=========================================
  Hits              ?      604           
  Misses            ?      443           
  Partials          ?       25           

Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see these changes being validated as part of the CI. Could we set enableMonitoring=true as part of e2e_arc_test and check these pods are up and running as a confirmation in the CI?

@nilekhc
Copy link
Contributor Author

nilekhc commented Mar 28, 2023

I don't see these changes being validated as part of the CI. Could we set enableMonitoring=true as part of e2e_arc_test and check these pods are up and running as a confirmation in the CI?

@aramase I added a check and it's passing in test run -
https://dev.azure.com/AzureContainerUpstream/Secrets%20Store%20CSI%20Driver%20Provider%20Azure/_build/results?buildId=84644&view=logs&j=635f5725-01ef-54e0-2420-bc6282236cc8&t=72aaed19-673d-56a4-af6e-e330415d20fd&l=66

@nilekhc nilekhc force-pushed the update-msi-adapter branch 2 times, most recently from 6d4db4e to 7119a7f Compare March 28, 2023 01:13
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@aramase
Copy link
Member

aramase commented Mar 28, 2023

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nilekhc nilekhc merged commit 932639f into Azure:master Mar 28, 2023
19 of 24 checks passed
@nilekhc nilekhc deleted the update-msi-adapter branch March 28, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants