New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds outbound proxy env variable support for windows pod #1106
Conversation
6cb6782
to
23f13d5
Compare
Codecov Report
@@ Coverage Diff @@
## master #1106 +/- ##
=======================================
Coverage 56.34% 56.34%
=======================================
Files 10 10
Lines 1072 1072
=======================================
Hits 604 604
Misses 443 443
Partials 25 25 |
23f13d5
to
ceb1ce7
Compare
/azp run pr-e2e-azure |
Azure Pipelines successfully started running 1 pipeline(s). |
cc @sozercan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the checksum comment, do we need to add this for monitoring for windows provider pods?
Lines 25 to 30 in e11dd11
{{- if .Values.enableArcExtension }} | |
{{- if .Values.arc.enableMonitoring }} | |
prometheus.io/scrape: "true" | |
prometheus.io/port: "8898" | |
{{- end }} | |
{{- end }} |
...ging/charts/csi-secrets-store-provider-azure/templates/provider-azure-installer-windows.yaml
Show resolved
Hide resolved
ceb1ce7
to
0689f1d
Compare
Added |
0689f1d
to
0fcdf0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
helm lint
is failing with
[ERROR] templates/: parse error at (csi-secrets-store-provider-azure/templates/provider-azure-installer-windows.yaml:107): unexpected EOF
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
0fcdf0e
to
8787f69
Compare
/azp run pr-e2e-azure |
Azure Pipelines successfully started running 1 pipeline(s). |
Reason for Change:
This PR adds outbound proxy env variable support for windows pod
Requirements
Issue Fixed:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Special Notes for Reviewers: