Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds outbound proxy env variable support for windows pod #1106

Merged
merged 1 commit into from Apr 5, 2023

Conversation

nilekhc
Copy link
Contributor

@nilekhc nilekhc commented Mar 31, 2023

Reason for Change:

This PR adds outbound proxy env variable support for windows pod

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Does this change contain code from or inspired by another project?

  • Yes
  • No

If "Yes," did you notify that project's maintainers and provide attribution?

Special Notes for Reviewers:

@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2023

Codecov Report

Merging #1106 (8787f69) into master (d3bc4c3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1106   +/-   ##
=======================================
  Coverage   56.34%   56.34%           
=======================================
  Files          10       10           
  Lines        1072     1072           
=======================================
  Hits          604      604           
  Misses        443      443           
  Partials       25       25           

@nilekhc nilekhc marked this pull request as ready for review March 31, 2023 01:34
@nilekhc nilekhc requested a review from aramase as a code owner March 31, 2023 01:34
@nilekhc
Copy link
Contributor Author

nilekhc commented Mar 31, 2023

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nilekhc
Copy link
Contributor Author

nilekhc commented Mar 31, 2023

cc @sozercan

Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the checksum comment, do we need to add this for monitoring for windows provider pods?

{{- if .Values.enableArcExtension }}
{{- if .Values.arc.enableMonitoring }}
prometheus.io/scrape: "true"
prometheus.io/port: "8898"
{{- end }}
{{- end }}

@nilekhc
Copy link
Contributor Author

nilekhc commented Apr 4, 2023

In addition to the checksum comment, do we need to add this for monitoring for windows provider pods?

{{- if .Values.enableArcExtension }}
{{- if .Values.arc.enableMonitoring }}
prometheus.io/scrape: "true"
prometheus.io/port: "8898"
{{- end }}
{{- end }}

Added

Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

helm lint is failing with

[ERROR] templates/: parse error at (csi-secrets-store-provider-azure/templates/provider-azure-installer-windows.yaml:107): unexpected EOF

Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@aramase
Copy link
Member

aramase commented Apr 4, 2023

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nilekhc nilekhc merged commit 6becac0 into Azure:master Apr 5, 2023
26 checks passed
@nilekhc nilekhc deleted the windows-proxy-support branch April 5, 2023 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants