feat: use the azsecrets, azkeys, azcertificates keyvault sdk
#1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramase
force-pushed
the
aramase/f/az_keyvault_sdk
branch
from
809a8a9
to
8e60a82
Compare
Codecov Report
@@ Coverage Diff @@
## master #1109 +/- ##
==========================================
+ Coverage 56.34% 61.72% +5.38%
==========================================
Files 10 11 +1
Lines 1072 1079 +7
==========================================
+ Hits 604 666 +62
+ Misses 443 386 -57
- Partials 25 27 +2 |
aramase
force-pushed
the
aramase/f/az_keyvault_sdk
branch
3 times, most recently
from
2630ff7
to
265433f
Compare
|
/azp run pr-e2e-azure |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This PR is stale because it has been open 14 days with no activity. Please comment or this will be closed in 7 days. |
aramase
force-pushed
the
aramase/f/az_keyvault_sdk
branch
from
265433f
to
11f94eb
Compare
* add keyvault interface * update auth to remove adapter and return token cred * implement keyvault interface and cleanup url usage * update e2e tests to use azsecrets * add mock_keyvault and initial unit test * remove getObjectVersion helper and use id.Version() * add unit test for getsecret * add unit test for getcerts Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
aramase
force-pushed
the
aramase/f/az_keyvault_sdk
branch
from
11f94eb
to
99c54f7
Compare
|
/azp run pr-e2e-azure |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nilekhc
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #997