feat: expose metrics port in helm charts #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree company="Microsoft" |
aramase
reviewed
Apr 14, 2023
There was a problem hiding this comment.
Thank you for the PR, @Suraiya-Hameed! Could you also add this change in the helm charts?
|
Done, PTAL |
aramase
requested changes
Apr 18, 2023
There was a problem hiding this comment.
For the charts changes, please update the yamls in the manifest_staging/ folder, where we host the staging charts and deployment yamls. All the yaml changes will then be promoted into the released charts folder with the next release.
|
/azp run pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
aramase
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1119 +/- ##
=======================================
Coverage 56.39% 56.39%
=======================================
Files 10 10
Lines 1071 1071
=======================================
Hits 604 604
Misses 443 443
Partials 24 24 |
nilekhc
reviewed
Apr 18, 2023
...fest_staging/charts/csi-secrets-store-provider-azure/templates/provider-azure-installer.yaml
Outdated
Show resolved
Hide resolved
Suraiya-Hameed
force-pushed
the
master
branch
3 times, most recently
from
ea0601a
to
14d7c97
Compare
nilekhc
requested changes
Apr 18, 2023
manifest_staging/charts/csi-secrets-store-provider-azure/values.yaml
Outdated
Show resolved
Hide resolved
manifest_staging/charts/csi-secrets-store-provider-azure/values.yaml
Outdated
Show resolved
Hide resolved
aramase
reviewed
Apr 19, 2023
manifest_staging/charts/csi-secrets-store-provider-azure/arc-values.yaml
Outdated
Show resolved
Hide resolved
|
/azp run pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
aramase
requested changes
Apr 19, 2023
manifest_staging/deployment/provider-azure-installer-windows.yaml
Outdated
Show resolved
Hide resolved
|
/azp run pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run pr-e2e-azure |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nilekhc
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Exposing port to scrape metrics in PodMonitor.
Similar to https://github.com/kubernetes-sigs/secrets-store-csi-driver/blob/22b661d0bbaa896127726dbf9fd1c9c1e3d27230/manifest_staging/deploy/secrets-store-csi-driver.yaml#L69-L75
Requirements
Issue Fixed:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Special Notes for Reviewers: