Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: telegraf response_timeout to timeout #1616

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

haodeon
Copy link
Contributor

@haodeon haodeon commented Jul 18, 2024

Reason for Change:

Telegraf sidecar in akvsecretsprovider-arc-monitoring pod is crashing upon startup because telegraf.conf uses deprecated option response_timeout.

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Does this change contain code from or inspired by another project?

  • Yes
  • No

If "Yes," did you notify that project's maintainers and provide attribution?

Special Notes for Reviewers:

nilekhc
nilekhc previously approved these changes Jul 18, 2024
@nilekhc nilekhc enabled auto-merge (squash) July 18, 2024 19:31
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the yamls in the manifest_staging/ folder and revert any changes in charts/.

manifest_staging folder is where we host the staging charts and deployment yamls. All the yaml changes will then be promoted into the released charts folder with the next release.

auto-merge was automatically disabled July 18, 2024 21:41

Head branch was pushed to by a user without write access

@haodeon haodeon requested review from nilekhc and aramase July 18, 2024 21:43
@nilekhc
Copy link
Contributor

nilekhc commented Jul 19, 2024

/azp run pr-e2e-azure

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nilekhc
Copy link
Contributor

nilekhc commented Jul 22, 2024

/azp run pr-e2e

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nilekhc nilekhc enabled auto-merge (squash) July 22, 2024 17:56
@nilekhc nilekhc merged commit ac7d27d into Azure:master Jul 22, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants