feat: add object format to support pfx #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR looks great! Can you pls add a e2e for this? |
aramase
force-pushed
the
pfx-or-pem
branch
3 times, most recently
from
fe4eb8b
to
9451c5c
Compare
|
/azp run pr-e2e-azure |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
objectFormatfield that user can configure topemorpfx. Default format ispem.pfxwill return the raw data (base64 encoded) as is from the Key VaultobjectFormat: pfxis only supported withobjectType: secretas key vault only supports pfx format for type secret.keyandcertobjects are returned inpemformat.Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #138
Special notes for your reviewer:
az keyvault secret downloadThis change adds a similar behavior, providing user the option to set
objectFormat: pfxfor secret type.