Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update README.md to clarify objectAlias for secret sync #280

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

ahmedkhamessi
Copy link
Contributor

check out this issue #270

Reason for Change:

This PR will help future users to sync keyvault secrets with kubernetes secrets due to a clearer documentation

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Fixes #270
Please answer the following questions with yes/no:

  • Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
    no
    Special Notes for Reviewers:

check out this issue Azure#270
@aramase aramase merged commit 0d82de6 into Azure:master Oct 21, 2020
jacmba added a commit to jacmba/secrets-store-csi-driver-provider-azure that referenced this pull request Oct 23, 2020
@aramase aramase changed the title Update README.md docs: update README.md to clarify objectAlias for secret sync Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kubernetes Secret Sync Requires the alias as an ObjectName
2 participants