Allow the 'updateStrategy' of the Daemonset to be configured in Helm #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run pr-e2e-azure |
|
Azure Pipelines successfully started running 1 pipeline(s). |
aramase
requested changes
Oct 23, 2020
There was a problem hiding this comment.
@chrisamert These changes need to be made in the manifest_staging dir where we currently host the staging charts. All the chart changes are then tagged with the release. Could you make the changes only in manifest_staging/charts instead
|
Ahh I missed that. I'll get these changes moved over |
This PR enables the 'updateStrategy' of the Daemonset to be configured by Helm parameters. The default values are the same as the current defaults; RollingUpdate strategy with maxUnavailable set to 1, so behavior will change only if the user specifies a custom value.
chrisamert
force-pushed
the
addUpdateStrategyToHelmParameters
branch
from
a51a325
to
422edb4
Compare
|
Adding the default values from docs here for future reference- Ref docs: |
|
/azp run pr-e2e-azure |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR enables the 'updateStrategy' of the Daemonset to be configured by Helm parameters. The default values are the same as the current defaults; RollingUpdate strategy with maxUnavailable set to 1, so behavior will change only if the user specifies a custom value.
Requirements
Issue Fixed:
Fixes #283 283
Please answer the following questions with yes/no:
Special Notes for Reviewers: