Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: helm dep update for lint + lint manifest_staging #288

Merged
merged 1 commit into from
Oct 28, 2020
Merged

chore: helm dep update for lint + lint manifest_staging #288

merged 1 commit into from
Oct 28, 2020

Conversation

aramase
Copy link
Member

@aramase aramase commented Oct 27, 2020

Reason for Change:

  • Update deps for helm lint
  • Enable helm lint for manifest_staging

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Please answer the following questions with yes/no:

  • Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

Special Notes for Reviewers:

@aramase aramase requested a review from ritazh October 27, 2020 06:24
@aramase aramase added the test label Oct 27, 2020
ritazh
ritazh reviewed Oct 28, 2020
View reviewed changes
.gitignore Show resolved Hide resolved
@aramase aramase requested a review from ritazh October 28, 2020 16:39
ritazh
ritazh approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aramase aramase merged commit 46ac819 into Azure:master Oct 28, 2020
@aramase aramase deleted the helm-linter branch October 28, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritazh ritazh ritazh approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aramase @ritazh