Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch to klog v2 and structured logging #299

Merged
merged 1 commit into from
Nov 6, 2020

Conversation

aramase
Copy link
Member

@aramase aramase commented Nov 3, 2020

Reason for Change:

  • Switch to using klog/v2
  • Enable structured logging
  • Bump dependencies and go version to 1.15
  • Reorganize imports
import(
  <standard libs>

  <internal libs>

  <external libs>
)

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

fixes #245
fixes #207

Please answer the following questions with yes/no:

  • Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

Special Notes for Reviewers:

@aramase aramase force-pushed the klog/v2 branch 3 times, most recently from bcb1d79 to 248b6e3 Compare November 3, 2020 21:58
@aramase aramase requested a review from ritazh November 3, 2020 22:07
@aramase aramase added this to the 0.0.10 milestone Nov 3, 2020
@aramase aramase added the enhancement New feature or request label Nov 5, 2020
Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aramase
Copy link
Member Author

aramase commented Nov 6, 2020

I1106 01:07:19.312951       1 main.go:77] Listening for connections on address: //provider/azure.sock
I1106 01:07:28.739053       1 provider.go:239] "unmarshaled key vault objects" keyVaultObjects=[{ObjectName:secret1 ObjectAlias: ObjectVersion: ObjectType:secret ObjectFormat: ObjectEncoding:} {ObjectName:secret2 ObjectAlias: ObjectVersion: ObjectType:secret ObjectFormat: ObjectEncoding:} {ObjectName:ingress-tls-pfx ObjectAlias: ObjectVersion: ObjectType:secret ObjectFormat:pfx ObjectEncoding:}] count=3 pod="default/nginx-66b6676558-79qt5"
I1106 01:07:28.739155       1 provider.go:250] "fetching object from key vault" objectName="secret1" objectType="secret" keyvault="kindkv" pod="default/nginx-66b6676558-79qt5"
I1106 01:07:28.742429       1 auth.go:148] "using service principal to retrieve access token" clientID="c68a##### REDACTED #####e807" secret="058c##### REDACTED #####89f6" pod="default/nginx-66b6676558-79qt5"
I1106 01:07:33.034496       1 provider.go:283] "successfully wrote file" file="secret1" pod="default/nginx-66b6676558-79qt5"
I1106 01:07:33.034555       1 provider.go:250] "fetching object from key vault" objectName="secret2" objectType="secret" keyvault="kindkv" pod="default/nginx-66b6676558-79qt5"
I1106 01:07:33.034736       1 auth.go:148] "using service principal to retrieve access token" clientID="c68a##### REDACTED #####e807" secret="058c##### REDACTED #####89f6" pod="default/nginx-66b6676558-79qt5"
I1106 01:07:33.550613       1 provider.go:283] "successfully wrote file" file="secret2" pod="default/nginx-66b6676558-79qt5"
I1106 01:07:33.550677       1 provider.go:250] "fetching object from key vault" objectName="ingress-tls-pfx" objectType="secret" keyvault="kindkv" pod="default/nginx-66b6676558-79qt5"
I1106 01:07:33.553670       1 auth.go:148] "using service principal to retrieve access token" clientID="c68a##### REDACTED #####e807" secret="058c##### REDACTED #####89f6" pod="default/nginx-66b6676558-79qt5"
I1106 01:07:34.300845       1 provider.go:283] "successfully wrote file" file="ingress-tls-pfx" pod="default/nginx-66b6676558-79qt5"

@aramase aramase merged commit f70f6f5 into Azure:master Nov 6, 2020
@aramase aramase deleted the klog/v2 branch November 6, 2020 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

Update to go 1.15 (feat): structured log
2 participants