Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add pprof profiling #329

Merged
merged 1 commit into from Dec 8, 2020
Merged

feat: add pprof profiling #329

merged 1 commit into from Dec 8, 2020

Conversation

aramase
Copy link
Member

@aramase aramase commented Nov 30, 2020

Enables profiling using pprof and also logs the current AKV provider
version at startup.

Reason for Change:

  • Adds pprof profiling
  • Adds logs for current AKV provider version during startup

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Please answer the following questions with yes/no:

  • Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution? No

Special Notes for Reviewers:

@aramase aramase added this to the 0.0.11 milestone Nov 30, 2020
@aramase aramase requested a review from ritazh November 30, 2020 18:43
@aramase
feat: add pprof profiling
e9a2758 
Enables profiling using pprof and also logs the current AKV provider
version at startup.
@aramase aramase requested a review from sozercan December 8, 2020 17:44
sozercan
sozercan approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aramase aramase merged commit 562403b into Azure:master Dec 8, 2020
Secret Store CSI Azure Provider Roadmap automation moved this from In progress to Done Dec 8, 2020
@aramase aramase deleted the enable-profiling branch December 8, 2020 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sozercan sozercan sozercan approved these changes

@ritazh ritazh Awaiting requested review from ritazh

Assignees
No one assigned
Labels
None yet
Projects
Secret Store CSI Azure Provider Roadmap
  
Done
Milestone
0.0.11
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aramase @sozercan