Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove bats test suite #391

Merged
merged 2 commits into from
Feb 12, 2021
Merged

Conversation

aramase
Copy link
Member

@aramase aramase commented Feb 6, 2021

Reason for Change:

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Does this change contain code from or inspired by another project?

  • Yes
  • No

If "Yes," did you notify that project's maintainers and provide attribution?

Special Notes for Reviewers:

@aramase aramase added this to the 0.0.13 milestone Feb 6, 2021
@codecov-io
Copy link

codecov-io commented Feb 10, 2021

Codecov Report

Merging #391 (7cb285b) into master (d0a8e14) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #391   +/-   ##
=======================================
  Coverage   62.86%   62.86%           
=======================================
  Files           6        6           
  Lines         474      474           
=======================================
  Hits          298      298           
  Misses        144      144           
  Partials       32       32           

Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

I don't think we are testing pv/pvc in the driver or provider anymore. should we remove these?

@aramase
Copy link
Member Author

aramase commented Feb 12, 2021

I don't think we are testing pv/pvc in the driver or provider anymore. should we remove these?

Sounds good! I've removed it from the examples folder.

@aramase aramase merged commit 093a7bc into Azure:master Feb 12, 2021
@aramase aramase deleted the remove-bats-test branch February 12, 2021 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants