Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch to using multi-os image, update docs #416

Merged
merged 1 commit into from Mar 4, 2021

Conversation

aramase
Copy link
Member

@aramase aramase commented Feb 26, 2021

Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com

Reason for Change:

  • Updates image in examples, docs and e2e to k8s.gcr.io/e2e-test-images/busybox:1.29 multi-platform image.
  • Updates ingress manifest in example to reflect current state.
  • Removes windows specific manifests as all the manifests should work in linux and windows.

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

fixes #411

Does this change contain code from or inspired by another project?

  • Yes
  • No

If "Yes," did you notify that project's maintainers and provide attribution?

Special Notes for Reviewers:

@aramase aramase force-pushed the update-00 branch 2 times, most recently from 5d40fa8 to 80625ee Compare February 26, 2021 23:42
@aramase
Copy link
Member Author

aramase commented Mar 1, 2021

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #416 (89a7d0a) into master (0253083) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #416   +/-   ##
=======================================
  Coverage   62.86%   62.86%           
=======================================
  Files           6        6           
  Lines         474      474           
=======================================
  Hits          298      298           
  Misses        144      144           
  Partials       32       32           

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aramase aramase merged commit 04c1fae into Azure:master Mar 4, 2021
@aramase aramase deleted the update-00 branch March 4, 2021 18:58
@aramase aramase added this to the 0.0.14 milestone Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: add nodeSelector or specify multi platform image
3 participants