feat: switch to driver writing files #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramase
force-pushed
the
driver-write-file
branch
2 times, most recently
from
a4caa6a
to
3859e6e
Compare
aramase
force-pushed
the
driver-write-file
branch
11 times, most recently
from
c450320
to
f6cc67e
Compare
aramase
force-pushed
the
driver-write-file
branch
2 times, most recently
from
269b350
to
294b454
Compare
Codecov Report
@@ Coverage Diff @@
## master #460 +/- ##
==========================================
- Coverage 64.31% 63.02% -1.29%
==========================================
Files 7 7
Lines 510 522 +12
==========================================
+ Hits 328 329 +1
- Misses 148 159 +11
Partials 34 34 |
nilekhc
reviewed
May 11, 2021
aramase
force-pushed
the
driver-write-file
branch
2 times, most recently
from
9baef5a
to
671f447
Compare
|
/azp run pr-e2e-azure |
|
Azure Pipelines failed to run 1 pipeline(s). |
aramase
force-pushed
the
driver-write-file
branch
from
671f447
to
3466aa3
Compare
|
/azp run pr-e2e-azure |
|
Azure Pipelines successfully started running 1 pipeline(s). |
aramase
force-pushed
the
driver-write-file
branch
from
3466aa3
to
a2000c9
Compare
ritazh
reviewed
May 12, 2021
| CI_KIND_CLUSTER: true | ||
| AZURE_ENVIRONMENT_FILEPATH: "/etc/kubernetes/custom_environment.json" | ||
| ${{ if eq(driverWriteSecret, 'true') }}: | ||
| DRIVER_WRITE_SECRETS: true |
There was a problem hiding this comment.
As it's part of the if clause the space is required
ritazh
reviewed
May 12, 2021
ritazh
reviewed
May 12, 2021
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com> ci: update pipeline to test feature Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com> ci: update gotool to 1.16.3 Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
aramase
force-pushed
the
driver-write-file
branch
from
a2000c9
to
0c0d254
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com
Reason for Change:
--driver-write-secretsto allow the CSI driver to write secrets (this feature is available in CSI Driver v0.0.21+). Default is false. We will switch to true in the next releases based on testing.driver-write-secretsfeature.Requirements
Issue Fixed:
fixes #475
fixes kubernetes-sigs/secrets-store-csi-driver#460
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Special Notes for Reviewers: