Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add version response for provider #466

Merged
merged 1 commit into from Apr 13, 2021

Conversation

aramase
Copy link
Member

@aramase aramase commented Apr 12, 2021

Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com

Reason for Change:

  • Sends version response back to the driver

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Does this change contain code from or inspired by another project?

  • Yes
  • No

If "Yes," did you notify that project's maintainers and provide attribution?

Special Notes for Reviewers:

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase requested review from ritazh and sozercan April 12, 2021 17:19
@codecov-io
Copy link

Codecov Report

Merging #466 (7ff9721) into master (6470ab6) will increase coverage by 0.28%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #466      +/-   ##
==========================================
+ Coverage   64.03%   64.31%   +0.28%     
==========================================
  Files           7        7              
  Lines         506      510       +4     
==========================================
+ Hits          324      328       +4     
  Misses        148      148              
  Partials       34       34              

@aramase aramase added this to the 0.0.15 milestone Apr 12, 2021
Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aramase aramase merged commit 72a2c0b into Azure:master Apr 13, 2021
@aramase aramase deleted the version-request branch April 13, 2021 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants