Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implements upgrade test #489

Merged
merged 95 commits into from May 10, 2021
Merged

Conversation

nilekhc
Copy link
Contributor

@nilekhc nilekhc commented Apr 28, 2021

Reason for Change:

Implements upgrade tests to validate backward compatibility.

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

fixes #305
fixes #459

Does this change contain code from or inspired by another project?

  • Yes
  • No

If "Yes," did you notify that project's maintainers and provide attribution?

Special Notes for Reviewers:

@nilekhc nilekhc requested a review from aramase April 28, 2021 21:46
@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2021

Codecov Report

Merging #489 (8eaf13d) into master (e44843e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #489   +/-   ##
=======================================
  Coverage   64.31%   64.31%           
=======================================
  Files           7        7           
  Lines         510      510           
=======================================
  Hits          328      328           
  Misses        148      148           
  Partials       34       34           

@nilekhc nilekhc marked this pull request as ready for review April 30, 2021 00:10
test/e2e/e2e_suite_test.go Outdated Show resolved Hide resolved
test/e2e/framework/helm/helm.go Outdated Show resolved Hide resolved
test/e2e/framework/helm/helm.go Outdated Show resolved Hide resolved
test/e2e/framework/helm/helm.go Outdated Show resolved Hide resolved
.pipelines/e2e-tests-template.yaml Outdated Show resolved Hide resolved
test/e2e/e2e_suite_test.go Show resolved Hide resolved
test/e2e/framework/config.go Outdated Show resolved Hide resolved
test/e2e/framework/helm/helm.go Outdated Show resolved Hide resolved
test/e2e/framework/namespace/namespace.go Outdated Show resolved Hide resolved
test/e2e/secret_test.go Outdated Show resolved Hide resolved
@aramase
Copy link
Member

aramase commented May 7, 2021

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

export HELM_CHART_DIR=$(ls -h charts/*.tgz | sort --version-sort --field-separator=- --key=6 | tail -n 1)

#Image version of latest released chart
IMAGE_VERSION=0.0.14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is always latest, can we get this automatically?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this would be the latest appVersion (index 0) in index.yaml.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is targeted for e2e testing of backward compatibility and released helm chart. The other option is to rely on default values in values.yaml of released chart(which we manually updates while releasing)

test/e2e/e2e_suite_test.go Outdated Show resolved Hide resolved
@aramase aramase added this to the 0.0.15 milestone May 10, 2021
@nilekhc
Copy link
Contributor Author

nilekhc commented May 10, 2021

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nilekhc
Copy link
Contributor Author

nilekhc commented May 10, 2021

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aramase aramase requested a review from sozercan May 10, 2021 21:04
@aramase aramase merged commit 79abec1 into Azure:master May 10, 2021
@nilekhc nilekhc deleted the backward-compatibility branch August 17, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test for helm release Add test for backward compatibility
4 participants