Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use AddToScheme for the csi-secrets-store apis #499

Merged
merged 2 commits into from May 11, 2021

Conversation

aramase
Copy link
Member

@aramase aramase commented May 10, 2021

Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com

Reason for Change:

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Does this change contain code from or inspired by another project?

  • Yes
  • No

If "Yes," did you notify that project's maintainers and provide attribution?

Special Notes for Reviewers:

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase marked this pull request as ready for review May 10, 2021 16:32
@aramase aramase requested review from nilekhc and sozercan May 10, 2021 16:32
@aramase aramase added this to the 0.0.15 milestone May 10, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #499 (09bfc48) into master (79abec1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #499   +/-   ##
=======================================
  Coverage   64.31%   64.31%           
=======================================
  Files           7        7           
  Lines         510      510           
=======================================
  Hits          328      328           
  Misses        148      148           
  Partials       34       34           

@aramase aramase merged commit 769a45d into Azure:master May 11, 2021
@aramase aramase deleted the scheme branch May 11, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants