Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: adds e2e test for containerd on windows #612

Merged
merged 36 commits into from Aug 31, 2021

Conversation

nilekhc
Copy link
Contributor

@nilekhc nilekhc commented Aug 17, 2021

Signed-off-by: Nilekh Chaudhari 1626598+nilekhc@users.noreply.github.com

Reason for Change:

This PR adds e2e test for containerd on windows

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

fixes: #551
Does this change contain code from or inspired by another project?

  • Yes
  • No

If "Yes," did you notify that project's maintainers and provide attribution?

Special Notes for Reviewers:

Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@nilekhc
Copy link
Contributor Author

nilekhc commented Aug 17, 2021

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2021

Codecov Report

Merging #612 (a95bd22) into master (09703cc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #612   +/-   ##
=======================================
  Coverage   64.55%   64.55%           
=======================================
  Files           7        7           
  Lines         584      584           
=======================================
  Hits          377      377           
  Misses        173      173           
  Partials       34       34           

Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@nilekhc
Copy link
Contributor Author

nilekhc commented Aug 17, 2021

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@nilekhc
Copy link
Contributor Author

nilekhc commented Aug 17, 2021

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@nilekhc
Copy link
Contributor Author

nilekhc commented Aug 18, 2021

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@nilekhc
Copy link
Contributor Author

nilekhc commented Aug 18, 2021

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@nilekhc
Copy link
Contributor Author

nilekhc commented Aug 18, 2021

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@nilekhc
Copy link
Contributor Author

nilekhc commented Aug 18, 2021

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@nilekhc
Copy link
Contributor Author

nilekhc commented Aug 18, 2021

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@nilekhc
Copy link
Contributor Author

nilekhc commented Aug 18, 2021

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@nilekhc
Copy link
Contributor Author

nilekhc commented Aug 18, 2021

/azp run pr-e2e-azure

@nilekhc
Copy link
Contributor Author

nilekhc commented Aug 25, 2021

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@nilekhc nilekhc requested a review from aramase August 25, 2021 22:02
@aramase
Copy link
Member

aramase commented Aug 25, 2021

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this PR are only for AKS. We don't need to run this for aks-engine. Right now it's generating 6 jobs even though the aks-engine always uses the default runtime. I think we can just have 2 jobs in e2e-job-azure: 1 for aks (linux, windows-docker, windows-containerd) and other for aks-engine (linux and windows-docker/aks-engine default).

Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@nilekhc
Copy link
Contributor Author

nilekhc commented Aug 25, 2021

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nilekhc nilekhc requested a review from aramase August 26, 2021 00:29
@aramase
Copy link
Member

aramase commented Aug 26, 2021

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aramase
Copy link
Member

aramase commented Aug 31, 2021

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nilekhc
Copy link
Contributor Author

nilekhc commented Aug 31, 2021

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aramase
Copy link
Member

aramase commented Aug 31, 2021

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nilekhc
Copy link
Contributor Author

nilekhc commented Aug 31, 2021

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nilekhc nilekhc merged commit 954fd06 into Azure:master Aug 31, 2021
@nilekhc nilekhc deleted the containerd-test branch August 31, 2021 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add e2e test for windows containerd
3 participants