Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: refactor cleanup image template #613

Merged
merged 1 commit into from Aug 20, 2021
Merged

Conversation

aramase
Copy link
Member

@aramase aramase commented Aug 18, 2021

Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com

Reason for Change:

  • Refactor cleanup image template and include arm64 image cleanup

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Does this change contain code from or inspired by another project?

  • Yes
  • No

If "Yes," did you notify that project's maintainers and provide attribution?

Special Notes for Reviewers:

@codecov-commenter
Copy link

Codecov Report

Merging #613 (4910831) into master (07859c3) will not change coverage.
The diff coverage is n/a.

❗ Current head 4910831 differs from pull request most recent head 1b9850c. Consider uploading reports for the commit 1b9850c to get more accurate results

@@           Coverage Diff           @@
##           master     #613   +/-   ##
=======================================
  Coverage   64.00%   64.00%           
=======================================
  Files           7        7           
  Lines         589      589           
=======================================
  Hits          377      377           
  Misses        178      178           
  Partials       34       34           

@nilekhc
Copy link
Contributor

nilekhc commented Aug 18, 2021

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase
Copy link
Member Author

aramase commented Aug 19, 2021

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aramase aramase requested a review from nilekhc August 19, 2021 21:53
Copy link
Contributor

@nilekhc nilekhc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aramase aramase merged commit 0db55a5 into Azure:master Aug 20, 2021
@aramase aramase deleted the remove-arm64-e2e branch August 20, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants