chore: make --driver-write-secrets flag no-op
#617
Merged
+53
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramase
force-pushed
the
deprecate-driver-write-secrets
branch
from
48601a1
to
811dddc
Compare
aramase
changed the title
--driver-write-secrets flag no-op
Codecov Report
@@ Coverage Diff @@
## master #617 +/- ##
==========================================
+ Coverage 64.00% 64.55% +0.54%
==========================================
Files 7 7
Lines 589 584 -5
==========================================
Hits 377 377
+ Misses 178 173 -5
Partials 34 34 |
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
aramase
force-pushed
the
deprecate-driver-write-secrets
branch
from
811dddc
to
b96b2b9
Compare
|
/azp run pr-e2e-azure |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nilekhc
reviewed
Aug 23, 2021
|
@aramase just a small nit. Otherwise looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com
Reason for Change:
Driver write secrets feature has been enabled by default in
v0.1.0release. This PR makes the flag configuration no-op to not allow disabling the feature. The flag will be removed altogether from code, deployment and helm charts in n+2 releases.Requirements
Issue Fixed:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Special Notes for Reviewers: