Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adds default runtime #627

Merged
merged 1 commit into from Sep 1, 2021

Conversation

nilekhc
Copy link
Contributor

@nilekhc nilekhc commented Sep 1, 2021

Signed-off-by: Nilekh Chaudhari 1626598+nilekhc@users.noreply.github.com

Reason for Change:

This PR adds containerd as default containerRuntime in params.

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Does this change contain code from or inspired by another project?

  • Yes
  • No

If "Yes," did you notify that project's maintainers and provide attribution?

Special Notes for Reviewers:

Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@nilekhc
Copy link
Contributor Author

nilekhc commented Sep 1, 2021

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nilekhc nilekhc requested a review from aramase September 1, 2021 17:07
@codecov-commenter
Copy link

Codecov Report

Merging #627 (1286756) into master (954fd06) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #627   +/-   ##
=======================================
  Coverage   64.55%   64.55%           
=======================================
  Files           7        7           
  Lines         584      584           
=======================================
  Hits          377      377           
  Misses        173      173           
  Partials       34       34           

@nilekhc nilekhc merged commit b53a010 into Azure:master Sep 1, 2021
@nilekhc nilekhc deleted the default-container-runtime branch September 1, 2021 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants