chore: cleanup unit tests that have external dependency #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #635 +/- ##
==========================================
- Coverage 66.38% 64.39% -2.00%
==========================================
Files 7 7
Lines 601 601
==========================================
- Hits 399 387 -12
- Misses 169 181 +12
Partials 33 33 |
nilekhc
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com
Reason for Change:
Because of changes in Azure/go-autorest#613, the tests that depends on
adal.NewServicePrincipalTokenFromMSIwill fail as it requires the IMDS endpoints be available. There is currently no option to pass a custom msi endpoint to mimic the behavior. So this PR deletes the two test cases that depend on the function.The unit tests are not failing in the CI because the agents we're running the tests on are Azure VMs. So they have the IMDS endpoint.
Requirements
Issue Fixed:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Special Notes for Reviewers: