Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use ErrorS instead of Fatalf for structured logging #638

Merged
merged 1 commit into from Sep 15, 2021

Conversation

aramase
Copy link
Member

@aramase aramase commented Sep 14, 2021

Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com

Reason for Change:

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Does this change contain code from or inspired by another project?

  • Yes
  • No

If "Yes," did you notify that project's maintainers and provide attribution?

Special Notes for Reviewers:

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase
Copy link
Member Author

aramase commented Sep 14, 2021

/azp run e2e-pr

@aramase aramase enabled auto-merge (squash) September 14, 2021 06:04
@nilekhc
Copy link
Contributor

nilekhc commented Sep 14, 2021

/azp run e2e-azure-pr

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

Copy link
Contributor

@nilekhc nilekhc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aramase aramase merged commit 5f67a21 into Azure:master Sep 15, 2021
@aramase aramase deleted the structured-logs branch September 15, 2021 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants