Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add kubernetes version matrix for kind tests #642

Merged
merged 1 commit into from Sep 20, 2021

Conversation

aramase
Copy link
Member

@aramase aramase commented Sep 17, 2021

Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com

Reason for Change:

  • Adds kubernetes version matrix with kind for e2e tests
  • Refactors the pipeline to run more jobs in parallel

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Does this change contain code from or inspired by another project?

  • Yes
  • No

If "Yes," did you notify that project's maintainers and provide attribution?

Special Notes for Reviewers:

@aramase
Copy link
Member Author

aramase commented Sep 17, 2021

/azp run e2e-pr

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@aramase aramase force-pushed the update-pipeline branch 4 times, most recently from 0ff2b6e to ff8df4e Compare September 17, 2021 18:57
@aramase aramase marked this pull request as ready for review September 17, 2021 19:09
@aramase aramase enabled auto-merge (squash) September 17, 2021 19:11
@aramase aramase changed the title ci: add kuberentes version matrix for kind tests ci: add kubernetes version matrix for kind tests Sep 17, 2021
CI_KIND_CLUSTER: true
AZURE_ENVIRONMENT_FILEPATH: "/etc/kubernetes/custom_environment.json"
strategy:
matrix:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we are running with 4 k8s version and not 3?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.19 is still not EOL and 1.22 is the latest. Is there a reason we only want to run 3?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generally support n-2 right? (total 3 releases)

Copy link
Member Author

@aramase aramase Sep 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.19, 1.20 and 1.21 are the current supported versions. 1.22 is the latest which we're also running test against here. I think it's good to catch regressions with latest kubernetes versions earlier when they're available. WDYT?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Sounds good.

Also, Should we document explicit k8s version we are supporting? Something like currently supported k8s versions. What say?

Copy link
Member Author

@aramase aramase Sep 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm! We can add the current supported version and versions we test in our docs.

azure-pipelines.yml Outdated Show resolved Hide resolved
@aramase aramase force-pushed the update-pipeline branch 2 times, most recently from d1799d0 to 7223547 Compare September 17, 2021 20:53
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
steps:
- script: make unit-test
displayName: unit test
- script: bash <(curl -s https://codecov.io/bash) -C $(Build.SourceVersion)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opened #647

Copy link
Member Author

@aramase aramase Sep 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @sozercan!

Copy link
Contributor

@nilekhc nilekhc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aramase aramase merged commit 4e0b2f7 into Azure:master Sep 20, 2021
@aramase aramase deleted the update-pipeline branch September 20, 2021 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants