New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add kubernetes version matrix for kind tests #642
Conversation
/azp run e2e-pr |
Azure Pipelines failed to run 1 pipeline(s). |
0ff2b6e
to
ff8df4e
Compare
CI_KIND_CLUSTER: true | ||
AZURE_ENVIRONMENT_FILEPATH: "/etc/kubernetes/custom_environment.json" | ||
strategy: | ||
matrix: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we are running with 4 k8s version and not 3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.19 is still not EOL and 1.22 is the latest. Is there a reason we only want to run 3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We generally support n-2 right? (total 3 releases)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.19, 1.20 and 1.21 are the current supported versions. 1.22 is the latest which we're also running test against here. I think it's good to catch regressions with latest kubernetes versions earlier when they're available. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Sounds good.
Also, Should we document explicit k8s version we are supporting? Something like currently supported k8s versions. What say?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sgtm! We can add the current supported version and versions we test in our docs.
d1799d0
to
7223547
Compare
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
7223547
to
002fba0
Compare
steps: | ||
- script: make unit-test | ||
displayName: unit test | ||
- script: bash <(curl -s https://codecov.io/bash) -C $(Build.SourceVersion) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi - this is deprecated now https://docs.codecov.com/docs/about-the-codecov-bash-uploader
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opened #647
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @sozercan!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com
Reason for Change:
Requirements
Issue Fixed:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Special Notes for Reviewers: