Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace deprecated codecov uploader with GitHub action #648

Merged
merged 1 commit into from Sep 22, 2021

Conversation

aramase
Copy link
Member

@aramase aramase commented Sep 21, 2021

Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com

Reason for Change:

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

fixes #647

Does this change contain code from or inspired by another project?

  • Yes
  • No

If "Yes," did you notify that project's maintainers and provide attribution?

Special Notes for Reviewers:

@codecov-commenter
Copy link

Codecov Report

Merging #648 (d09d7fd) into master (72209e8) will decrease coverage by 1.64%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #648      +/-   ##
==========================================
- Coverage   64.39%   62.74%   -1.65%     
==========================================
  Files           7        7              
  Lines         601      765     +164     
==========================================
+ Hits          387      480      +93     
- Misses        181      252      +71     
  Partials       33       33              

@aramase aramase marked this pull request as ready for review September 21, 2021 23:57
@aramase aramase enabled auto-merge (squash) September 21, 2021 23:58
@nilekhc
Copy link
Contributor

nilekhc commented Sep 22, 2021

Do we have a sample run for this action?

@nilekhc
Copy link
Contributor

nilekhc commented Sep 22, 2021

Do we have a sample run for this action?

Got the run here:
https://github.com/Azure/secrets-store-csi-driver-provider-azure/runs/3669565302?check_suite_focus=true

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
Copy link
Contributor

@nilekhc nilekhc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aramase aramase merged commit c169615 into Azure:master Sep 22, 2021
@aramase aramase deleted the codecov branch September 22, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated codecov uploader
4 participants