-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds windows server 2022 #660
Conversation
@nick5616 Thanks for the PR! Could you re-base? |
Codecov Report
@@ Coverage Diff @@
## master #660 +/- ##
=======================================
Coverage 62.74% 62.74%
=======================================
Files 7 7
Lines 765 765
=======================================
Hits 480 480
Misses 252 252
Partials 33 33 |
/azp run pr-e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run pr-e2e-azure |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Reason for Change:
Adds Windows Server 2022 to
Makefile
,BASEIMAGE
, andBASEIMAGE_CORE
Requirements
Issue Fixed:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Special Notes for Reviewers:
ltsc2022 is the MCR tag for Windows Server 2022
https://hub.docker.com/_/microsoft-windows-nanoserver
There is a PR for the same thing here:
kubernetes-sigs/azuredisk-csi-driver#1030
kubernetes-sigs/secrets-store-csi-driver#756