New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow empty objects array #671
Conversation
Codecov Report
@@ Coverage Diff @@
## master #671 +/- ##
==========================================
- Coverage 62.74% 62.09% -0.66%
==========================================
Files 7 7
Lines 765 765
==========================================
- Hits 480 475 -5
- Misses 252 257 +5
Partials 33 33 |
f3c5b38
to
6117c63
Compare
/azp run pr-e2e-azure |
Commenter does not have sufficient privileges for PR 671 in repo Azure/secrets-store-csi-driver-provider-azure |
/azp run pr-e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
This PR is stale because it has been open 14 days with no activity. Please comment or this will be closed in 7 days. |
@aramase Can you review this? It's OK if we don't merge for some time. |
This PR is stale because it has been open 14 days with no activity. Please comment or this will be closed in 7 days. |
@aramase ? |
6117c63
to
c09afe0
Compare
/azp run pr-e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run pr-e2e-azure |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/azp run pr-e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
Reason for Change:
The YAML for secret provider class can be created by a template engine and all the objects listed there can depend on a template variable to be truthy. In this case, when all of them are falsy, it becomes a special case if empty objects array is not allowed. Example:
If
condition1
andcondition2
are both falsy, the provider returns an error, but simply mounting an empty volume would be more consistent and it doesn't require special handling.Requirements
Issue Fixed:
Does this change contain code from or inspired by another project?
Special Notes for Reviewers: