chore: switch to upstream acr #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
|
/azp run pr-e2e-azure |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run pr-e2e-azure |
|
Azure Pipelines successfully started running 1 pipeline(s). |
aramase
commented
Mar 25, 2022
Comment on lines
-17
to
-21
| # permission for ACR | ||
| if [[ -n "$(REGISTRY_NAME)" ]]; then | ||
| ID="$(az role assignment create --assignee-object-id "${ASSIGNEE_OBJECT_ID}" --assignee-principal-type "ServicePrincipal" --role "AcrPull" --scope "/subscriptions/$(SUBSCRIPTION_ID)/resourceGroups/k8sbuildci/providers/Microsoft.ContainerRegistry/registries/$(REGISTRY_NAME)" --query id -otsv)" | ||
| ROLE_ASSIGNMENT_IDS+="${ID} " | ||
| fi |
There was a problem hiding this comment.
upstream has anonymous pull enabled, so these permissions are no longer required
nilekhc
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com
Reason for Change:
Switching staging registry from using upstreamk8sci to upstream.
Requirements
Issue Fixed:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Special Notes for Reviewers: