Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add functions to get parameters and add constants #896

Merged
merged 2 commits into from May 24, 2022

Conversation

aramase
Copy link
Member

@aramase aramase commented May 23, 2022

Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com

Reason for Change:

  • Adds functions to get parameters from the attributes map
  • Adds unit tests to validate the get parameters functions
  • Makes the parameter names constant, so it can be reused in code and tests

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Does this change contain code from or inspired by another project?

  • Yes
  • No

If "Yes," did you notify that project's maintainers and provide attribution?

Special Notes for Reviewers:

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2022

Codecov Report

Merging #896 (e17c342) into master (e0ff59e) will increase coverage by 1.21%.
The diff coverage is 90.36%.

@@            Coverage Diff             @@
##           master     #896      +/-   ##
==========================================
+ Coverage   59.79%   61.00%   +1.21%     
==========================================
  Files           7        8       +1     
  Lines         868      895      +27     
==========================================
+ Hits          519      546      +27     
  Misses        314      314              
  Partials       35       35              

@aramase
Copy link
Member Author

aramase commented May 23, 2022

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase
Copy link
Member Author

aramase commented May 24, 2022

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aramase aramase marked this pull request as ready for review May 24, 2022 18:42
@aramase aramase requested a review from nilekhc May 24, 2022 18:42
pkg/provider/types/parameters.go Outdated Show resolved Hide resolved
pkg/provider/types/parameters_test.go Show resolved Hide resolved
pkg/provider/types/parameters_test.go Show resolved Hide resolved
pkg/provider/types/parameters_test.go Show resolved Hide resolved
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase requested a review from nilekhc May 24, 2022 22:25
@aramase aramase merged commit 82385a5 into Azure:master May 24, 2022
@aramase aramase deleted the refactor-part1 branch May 24, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants