Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use tenantID instead of tenantId in parameters #898

Merged
merged 1 commit into from May 26, 2022

Conversation

aramase
Copy link
Member

@aramase aramase commented May 25, 2022

Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com

Reason for Change:

  • Changes the tenant id parameter to tenantID from tenantId to be consistent with the naming convention.
  • This change is backward compatible as we fallback on tenantId in case tenantID is not set.
    • The TenantIDParameter constant can be changed to tenantID after 1.2 release as it's used in upgrade tests.
    • We'll need to keep the old tenantId parameter a couple of releases before we completely remove it.
    • The log is set at level 3 instead of warning, as warning can be too verbose and logged every time the we get a mount request.

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

fixes #857

Does this change contain code from or inspired by another project?

  • Yes
  • No

If "Yes," did you notify that project's maintainers and provide attribution?

Special Notes for Reviewers:

@aramase aramase marked this pull request as ready for review May 25, 2022 17:40
@aramase
Copy link
Member Author

aramase commented May 25, 2022

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aramase aramase requested a review from nilekhc May 25, 2022 19:00
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase enabled auto-merge (squash) May 26, 2022 00:26
@aramase aramase merged commit 858b765 into Azure:master May 26, 2022
@aramase aramase deleted the issue-857 branch May 26, 2022 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change tenantId to tenantID for consistency in naming
2 participants