feat: override priorityClassName from secrets-store-csi-driver subchart #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramase
requested changes
Jul 22, 2022
There was a problem hiding this comment.
Thank you for the PR!
Please update the yamls in the manifest_staging/ folder, where we host the staging charts and deployment yamls. All the yaml changes will then be promoted into the released charts folder with the next release.
jdweeks
force-pushed
the
csi-driver-priorityClassName
branch
from
c346475
to
79985b1
Compare
done! thanks |
|
/azp run pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #943 +/- ##
=======================================
Coverage 62.15% 62.15%
=======================================
Files 9 9
Lines 909 909
=======================================
Hits 565 565
Misses 311 311
Partials 33 33 |
aramase
approved these changes
Jul 22, 2022
nilekhc
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR adds the ability for end users of this chart to set the
priorityClassNamefor pods created by the subchartsecrets-store-csi-driver. This is useful to ensure that pods managed by the driver's DaemonSet are scheduled before application pods that depend on the driver.The values for both linux and windows are already implemented in the subchart (secrets-store-csi-driver). We simply need to override / expose them here for end users of this chart.
Requirements
Issue Fixed:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Special Notes for Reviewers: