Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: migrate ginkgo from v1 to v2 #969

Merged
merged 1 commit into from Sep 8, 2022
Merged

Conversation

aramase
Copy link
Member

@aramase aramase commented Sep 7, 2022

Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com

Reason for Change:

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Does this change contain code from or inspired by another project?

  • Yes
  • No

If "Yes," did you notify that project's maintainers and provide attribution?

Special Notes for Reviewers:

@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2022

Codecov Report

Merging #969 (2b90482) into master (aaffbe5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #969   +/-   ##
=======================================
  Coverage   59.18%   59.18%           
=======================================
  Files          10       10           
  Lines        1061     1061           
=======================================
  Hits          628      628           
  Misses        398      398           
  Partials       35       35           

@aramase aramase marked this pull request as ready for review September 7, 2022 22:38
@aramase
Copy link
Member Author

aramase commented Sep 7, 2022

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase
Copy link
Member Author

aramase commented Sep 8, 2022

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aramase aramase marked this pull request as ready for review September 8, 2022 18:29
@aramase aramase merged commit 44a1c40 into Azure:master Sep 8, 2022
@aramase aramase deleted the ginkgo-v2 branch September 8, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants