fix: updates template condition for Arc

[nilekhc]

Signed-off-by: Nilekh Chaudhari 1626598+nilekhc@users.noreply.github.com

Reason for Change:

Requirements

• squashed commits
• included documentation
• added unit tests and e2e tests (if applicable).

Issue Fixed:

fixes: #972
Does this change contain code from or inspired by another project?

• Yes
• No

If "Yes," did you notify that project's maintainers and provide attribution?

Special Notes for Reviewers:

[sozercan]

and didn't work here?

[nilekhc]

nope. It also tries to evaluate .Values.arc.enableMonitoring, which is not in values.yaml. It's in a separate file arc-values.yaml used while releasing ARC extension.

[aramase]

The scan_images failure should be resolved with #976.

Were you able to repro this? IIRC, in the last PR the order in which and operands were validated?

[nilekhc]

The scan_images failure should be resolved with #976.

Were you able to repro this? IIRC, in the last PR the order in which and operands were validated?

Yeah. I remember this. But I also remember when I first implemented this I had the same issue and exactly the same was the implementation to avoid nil pointer.

[aramase]

The scan_images failure should be resolved with #976.
Were you able to repro this? IIRC, in the last PR the order in which and operands were validated?

Yeah. I remember this. But I also remember when I first implemented this I had the same issue and exactly the same was the implementation to avoid nil pointer.

Is this a simple repro when not using an arc cluster? Is there a way we can catch this in CI/repro it with CI so we can validate this fix and ensure we don't hit this again?

[github-actions]

This PR is stale because it has been open 14 days with no activity. Please comment or this will be closed in 7 days.

[nilekhc]

The scan_images failure should be resolved with #976.
Were you able to repro this? IIRC, in the last PR the order in which and operands were validated?

Yeah. I remember this. But I also remember when I first implemented this I had the same issue and exactly the same was the implementation to avoid nil pointer.

Is this a simple repro when not using an arc cluster? Is there a way we can catch this in CI/repro it with CI so we can validate this fix and ensure we don't hit this again?

I have added a pod annotation in the e2e tests in the helm install. So if there is an issue, CI will give an error.

[nilekhc]

/azp run pr-e2e-azure

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[nilekhc]

/azp run pr-e2e-azure

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).