chore: update golangci-lint to v1.49.0 #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramase
commented
Sep 16, 2022
| @@ -6,7 +6,6 @@ run: | |||
| linters: | |||
| disable-all: true | |||
| enable: | |||
| - deadcode | |||
There was a problem hiding this comment.
WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused.
WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused.
WARN [runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused.
Codecov Report
@@ Coverage Diff @@
## master #977 +/- ##
==========================================
- Coverage 59.18% 58.91% -0.28%
==========================================
Files 10 10
Lines 1061 1066 +5
==========================================
Hits 628 628
- Misses 398 403 +5
Partials 35 35 |
aramase
commented
Sep 16, 2022
nilekhc
previously approved these changes
Sep 20, 2022
aramase
force-pushed
the
golangci-lint-v1.49.0
branch
from
08d974e
to
5525f2d
Compare
sozercan
reviewed
Sep 23, 2022
| @@ -16,6 +16,10 @@ import ( | |||
| "k8s.io/klog/v2" | |||
| ) | |||
|
|
|||
| const ( | |||
| readHeaderTimeout = 5 * time.Second | |||
There was a problem hiding this comment.
should we move this to utils package so it's shared?
There was a problem hiding this comment.
If we use constants from utils package, it'll lead to import cycle, that's why I defined them as local constants.
sozercan
approved these changes
Sep 23, 2022
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
aramase
force-pushed
the
golangci-lint-v1.49.0
branch
from
5525f2d
to
6d8a05a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com
Reason for Change:
v1.49.0Requirements
Issue Fixed:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Special Notes for Reviewers: