Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the documentation to specify v before 'version' and code changes to append 'v' if it not provided in version #11

Merged
merged 4 commits into from May 14, 2020

Conversation

rgsubh
Copy link
Contributor

@rgsubh rgsubh commented May 7, 2020

No description provided.

@rgsubh rgsubh requested a review from thesattiraju May 7, 2020 09:18
@rgsubh rgsubh changed the title Chnaged the documentation to sepcify v before 'version' Changed the documentation to specify v before 'version' May 7, 2020
README.md Outdated Show resolved Hide resolved
src/run.ts Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@rgsubh rgsubh requested a review from thesattiraju May 13, 2020 03:33
@rgsubh rgsubh changed the title Changed the documentation to specify v before 'version' Changed the documentation to specify v before 'version' and code changes to append 'v' if it not provided in version May 13, 2020
Copy link
Contributor

@thesattiraju thesattiraju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Test E2E before merging! 😄

@rgsubh rgsubh merged commit 98b8d3a into releases/v1 May 14, 2020
rgsubh added a commit that referenced this pull request May 14, 2020
…ges to append 'v' if it not provided in version (#11)

* Chnaged the documentation to sepcify v before 'version'

* append v to version incase it does not already include

* review comments fix
rgsubh added a commit that referenced this pull request May 14, 2020
…ges to append 'v' if it not provided in version (#11) (#15)

* Chnaged the documentation to sepcify v before 'version'

* append v to version incase it does not already include

* review comments fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants