Updating the logic for downloading latest Helm version #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesattiraju
approved these changes
May 13, 2020
| @@ -5,13 +5,14 @@ import * as os from 'os'; | |||
| import * as path from 'path'; | |||
| import * as util from 'util'; | |||
| import * as fs from 'fs'; | |||
| import * as semver from 'semver'; | |||
There was a problem hiding this comment.
Doesn't this need to be added to package.json?
There was a problem hiding this comment.
It was already there in node modules along with other packages and non of them are present in package.json. I'm not sure what's the criteria to add modules as dependencies in package.json
There was a problem hiding this comment.
Should I add it or leave it unchanged?
There was a problem hiding this comment.
Add it explicitly; we can't take dependencies on other packages to have semver all the time! :)
There was a problem hiding this comment.
I meant it's already present in node modules, but not as a part of another package. 😛
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the logic for downloading latest Helm version instead of last updated version of Helm release.