add GetFamilyName() functionality in skewer #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeldeib
reviewed
Mar 10, 2022
| // GetFamilyName returns the family name of this resource sku. It normalizes pointers | ||
| // to the empty string for comparison purposes. For example, | ||
| // "standardDSv2Family" for a virtual machine. | ||
| func (s *SKU) GetFamilyName() string { |
There was a problem hiding this comment.
could you add a unit test on this function in data_test.go? https://github.com/Azure/skewer/blob/main/data_test.go
gandhipr
force-pushed
the
prachigandhi-GetFamilyName
branch
from
f18f7b3
to
720b428
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetFamilyName() return Family name of the SKU.