Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable MIRROR_SNAPSHOT if SONIC_VERSION_CONTROL_COMPONENTS includes deb #17148

Merged
merged 1 commit into from May 19, 2024

Conversation

k-v1
Copy link
Contributor

@k-v1 k-v1 commented Nov 12, 2023

Why I did it

Fix #17113
If we set MIRROR_SNAPSHOT=y in build_mirror_config.sh
then we have incorrect value of MIRROR_SNAPSHOT in other places like buildinfo/config/buildinfo.config

Work item tracking
  • Microsoft ADO (number only):

How I did it

Override MIRROR_SNAPSHOT=y in rules/config if
SONIC_VERSION_CONTROL_COMPONENTS=all or
SONIC_VERSION_CONTROL_COMPONENTS includes deb component.

How to verify it

Start to build with different values of SONIC_VERSION_CONTROL_COMPONENTS and MIRROR_SNAPSHOT in cmdline
and check value of MIRROR_SNAPSHOT in buildinfo.config and debian mirrors in sources.list files

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@k-v1
Copy link
Contributor Author

k-v1 commented Nov 12, 2023

@xumia, please review.

@lguohan
Copy link
Collaborator

lguohan commented May 19, 2024

make sense to me. @xumia , i am merging it.

@lguohan lguohan merged commit 881abd3 into sonic-net:master May 19, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants