[master][build] fix compile error when enable nostrip #6058
+95
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tim-rj <sonic_rd@ruijie.com.cn>
3 tasks
tim-rj
changed the title
|
it seems DBG_TARGETS is newly introduced, can you rename it as DEBUG_TARGETS? |
renukamanavalan
previously approved these changes
Dec 2, 2020
ok |
Signed-off-by: tim-rj <sonic_rd@ruijie.com.cn>
|
what is the use case to enable nostrip option during the build? I am not aware of this. @tim-rj , @renukamanavalan , what is the use case here? |
|
@lguohan when enable SONIC_DEBUGGING_ON or SONIC_PROFILING_ON micro, "notrip“” option will be added in slave.mk. |
lguohan
reviewed
Dec 25, 2020
src/hiredis/Makefile
Outdated
|
|
||
| ifneq ($(findstring nostrip,$(DEB_BUILD_OPTIONS)),nostrip) | ||
| $(eval DERIVED_TARGETS += $(DEBUG_TARGETS)) | ||
| endif |
There was a problem hiding this comment.
this is common across different Makefile, then I think it is better to be move to common place.
3 tasks
Signed-off-by: tim-rj <sonic_rd@ruijie.com.cn>
|
help forward this, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tim-rj sonic_rd@ruijie.com.cn
- Why I did it
fix #5982
- How I did it
check notrip option before handle dbgsym debs
- How to verify it
set SONIC_DEBUGGING_ON=y / SONIC_PROFING_ON=y and compile the whole image
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
If SONIC_DEBUG_ON or SONIC_PROFILING_ON set to y, no dbgsym debs will be stripped from the origin deb, so mv dbgsym deb to some other folders will fail and compiling will stop.
- A picture of a cute animal (not mandatory but encouraged)