[as7816-64x]Modify to check specific DUT #7826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jostar Yang <jostar_yang@accton.com.tw>
FuzailBrcm
reviewed
Jun 9, 2021
| @@ -3182,8 +3182,8 @@ | |||
| "i2c" : { | |||
| "attr_list": | |||
| [ | |||
| {"attr_name":"STATUS_LED_COLOR_AMBER", "descr" : "Amber", "bits" : "4", "value" : "0x0", "swpld_addr" : "0x60", "swpld_addr_offset" : "0x30"}, | |||
| {"attr_name":"STATUS_LED_COLOR_OFF", "descr" : "Off", "bits" : "4", "value" : "0x1", "swpld_addr" : "0x60", "swpld_addr_offset" : "0x30"} | |||
| {"attr_name":"amber", "descr" : "Amber", "bits" : "4", "value" : "0x0", "swpld_addr" : "0x60", "swpld_addr_offset" : "0x30"}, | |||
There was a problem hiding this comment.
Please remove these changes and all other changes in pddf-device.json file
There was a problem hiding this comment.
done to modify back pddf-device.json
FuzailBrcm
previously approved these changes
Jun 9, 2021
4 tasks
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
FuzailBrcm
approved these changes
Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jostar Yang jostar_yang@accton.com.tw
Why I did it
AS7816 support AT or non-AT DUT. They use different pmbus i2c bus. So use "pre_pddf_init.sh" to check this case.
How I did it
Add pre_pddf_init.sh.
How to verify it
Add pre_pddf_init.sh to build image. Load to check on AT DUT. PSU work well.
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)