[multi-asic][cli][chassis-db] Avoid connecting to chassis db when cli commands are executed from linecards #8065
Conversation
|
@lguohan - would you like to opt out of reviewing this PR? |
|
Hi @mlorrillere - could you please review, thanks. |
|
Hi @vganesan-nokia , It seems that on a multi-asic pizza box this would require to configure VOQ_SUPERVISOR=1 as well. Would it make more sense to rely on start_chassis_db=1 set in chassisdb.conf to connect to chassis db from CLI? |
Hi @mlorrillere, In multi-asic pizza box systems which are not distributed VOQ systems, we always want to avoid connecting to chassis databases since they do not exist in pizza box systems. Simply not having this VOQ_SUPERVISOR variable in the asic.conf (as it is today in multi-asic pizza box systems) will be enough. If we do not have this variable defined, we'll skip connecting to chassis databases. Also chassisdb.conf may not exist in pizza box systems |
Right, but on a multi-asic pizza box that is a VOQ system, we would need to set VOQ_SUPERVISOR=1. Am I correct? |
I see. In that case, I imagine, we'll be running the redis-chassis server (where the chassis databases are hosted) along with other asic instance specific redis servers in the same box. The VOQ pizza box behaves like a supervisor card in addition to being a line card or vice versa. I think setting VOQ_SUPERVISOR=1 in this case is o.k. and connecting to the chassis databases should be fine. Using chassisdb.conf vs asic,conf for VOQ_SUPERVISOR: The existing CLI implementation has tested infra apis for setting path for asic.conf for file access. I just made use of it. If we have to use chassisdb.conf, we need to add additional code similar to asic.conf path setting apis for file access. I see using chassisdb.conf avoids using an additional variable in asic.conf. Otherwise start_chassis_db in chassisdb.conf and VOQ_SUPERVISOR in asic.conf give same information (that the host is a supervisor card). I do not see any significant advantage in choosing chassisdb.conf over asic.conf. If avoiding using additional variable in asic.conf is preferred over adding additional code for chassisdb.conf, I can do the modifications. |
vganesan-nokia
force-pushed
the
cli_chassis_db-1
branch
from
b6b327e
to
ba0a223
Compare
Currently, for all the cli commands, we connect to all databases mentioned in the database_config.json. The database_config.json also includes the databases from chassis redis server from supervisor card. It is unneccessary to connect to databases from chassis redis server when cli commands are executed form linecard. But we need to allow connection to chassis databases when the cli commands are executed from supervisor card. The changes in this PR fixes this problem. This PR requires that asic.conf in supervisor card includes VOQ_SUPERVISOR with value 1 to indentify the supervisor card. The connect_to_all_dbs_for_ns() is changed to skip chassis databases form the list of collected databases if the card is not supervisor card. Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com>
- is_voq_supervisor() renamed to is_supervisor() since this API is applicable to non VOQ chassis also - Determination of supervisor card type is done using "supervisor" variable from platfrom_env.conf instead of from asic.conf - Removed changes unrelated to this fix. Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com>
|
@vganesan-nokia, can you resolve the conflicts ? |
vganesan-nokia
force-pushed
the
cli_chassis_db-1
branch
from
ba0a223
to
11ac31c
Compare
|
@arlakshm, I force pushed to resolve the conflict. But the build seems to be stuck. Would you please re-start the azure pipeline? Thanks |
|
/Azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| if not is_supervisor(): | ||
| try: | ||
| db_list.remove('CHASSIS_APP_DB') | ||
| db_list.remove('CHASSIS_STATE_DB') |
There was a problem hiding this comment.
Good to have an function returning back a list of chassis db instances in supervisor.
But it is ok to do it later as well.
… commands are executed from linecards (#8065) * [multi-asic][cli][chassis-db] Avoiding connecting to chassis db Currently, for all the cli commands, we connect to all databases mentioned in the database_config.json. The database_config.json also includes the databases from chassis redis server from supervisor card. It is unneccessary to connect to databases from chassis redis server when cli commands are executed form linecard. But we need to allow connection to chassis databases when the cli commands are executed from supervisor card. The changes in this PR fixes this problem. This PR requires that asic.conf in supervisor card includes VOQ_SUPERVISOR with value 1 to indentify the supervisor card. The connect_to_all_dbs_for_ns() is changed to skip chassis databases form the list of collected databases if the card is not supervisor card.
Why I did it
Currently, for all the cli commands, we connect to all databases mentioned in the database_config.json. The database_config.json also includes the databases from chassis redis server from supervisor card. It is unnecessary to connect to databases from chassis redis server when cli commands are executed form linecard. But we need to allow connection to chassis databases when the cli commands are executed from supervisor card. This PR fixes this problem
How I did it
This PR requires that platform_env.conf in supervisor card includes a variable "supervisor" with value 1 to identify the supervisor card. The connect_to_all_dbs_for_ns() is changed to skip chassis databases form the list of collected databases if the card is not supervisor card. This PR requires sonic-utilities PR sonic-net/sonic-utilities#1707 to have complete fix
How to verify it
In voq chassis, execute cli commands (show, config etc.) and make sure that commands are successful irrespective whether there is supervisor card or not.
Which release branch to backport (provide reason below if selected)
N/A
Description for the changelog
multi-asic cli to skip connecting to chassis databases when commands are executed from line card.