[AS7726-32X] Add to support mulit PSU SN in PDDF #8164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jostar Yang <jostar_yang@accton.com.tw>
FuzailBrcm
previously approved these changes
Jul 13, 2021
lguohan
approved these changes
Jul 25, 2021
lguohan
reviewed
Jul 25, 2021
| #include <linux/sysfs.h> | ||
| #include <linux/slab.h> | ||
| #include <linux/dmi.h> | ||
| #include "../../../../pddf/i2c/modules/include/pddf_psu_defs.h" |
There was a problem hiding this comment.
there are too many pddf directory in the sonic-buildimage, we should add the include path in the search path and build.
There was a problem hiding this comment.
@jostar-yang
Can you take care of this comment?
FuzailBrcm
reviewed
Jul 28, 2021
| }; | ||
|
|
||
| struct serial_number_info serials[] = { | ||
| {PSU_TYPE_AC_110V, 0x2e, 18, 18, "YM-2651Y"}, |
There was a problem hiding this comment.
Can you re-check this and correct the offset if needed?
There was a problem hiding this comment.
as7726 support YM-2651Y PSU. So need this code.
5 tasks
FuzailBrcm
reviewed
Jan 3, 2022
| ] | ||
| } | ||
| }, | ||
| "PSU2-EEPROM": | ||
| { | ||
| "dev_info": { "device_type":"PSU-EEPROM", "device_name":"PSU1-EEPROM", "device_parent":"MUX7", "virt_parent":"PSU2"}, |
There was a problem hiding this comment.
"device_name":"PSU1-EEPROM" ---------> this should be "PSU2-EEPROM"
FuzailBrcm
approved these changes
Jan 3, 2022
prgeor
approved these changes
Feb 7, 2022
lguohan
approved these changes
Feb 7, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jostar Yang jostar_yang@accton.com.tw
Why I did it
This DUT support different PSU
How I did it
Add drv code to read from PSU eeprom to get model name and then get serial number
How to verify it
Test via pddf_psu cmd,
root@sonic:/home/admin# pddf_psuutil mfrinfo
PSU Status Manufacturer ID Model Serial Fan Airflow Direction
PSU1 OK ACBEL FSF019-611 FSF0192105002864 EXHAUST
PSU2 OK 3Y POWER YM-2651Y SA070V581905000055 EXHAUST
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)