[common]: Fix of get_port_map

[vmorokhx]

Signed-off-by: Vladyslav Morokhovych vladyslavx.morokhovych@intel.com

Description of PR

Summary:
Patch with fix for get_port_map in interface_utils.py
According to Porting Guide: plugins/getportmap.py and port_config.ini are deprecated, but was used in get_port_map

Type of change

• Bug fix
• Testbed and Framework(new/improvement)
• Test case(new/improvement)

Back port request

• 201911

Approach

What is the motivation for this PR?

Deprecation of

• plugins/getportmap.py
• port_config.ini ( In favor of the use of platform.json and hwsku.json )

How did you do it?

Change get_port_map in interface_utils.py
Switched from using getportmap.py and port_config.ini
to retrieving port mapping from config_facts depending on asic

How did you verify/test it?

Run sfp tests, test_reboot.py, test_sequential_restart.py on t0, t0-64-32 and t1

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

[lgtm-com]

This pull request introduces 1 alert when merging cbfafb1 into 4309468 - view on LGTM.com

new alerts:

• 1 for Unused import

[wangxin]

@vmorokhx Can you fix the LTM alert 1 for Unused import?

[vmorokhx]

@wangxin LGTM unused import alert fixed.

[rawal01]

@wangxin @shubav
This breaks multi asic platforms as platform.json is not have support for multi asic platforms we are using port_config.ini to get the information after this change it breaks sfp and reboot test for voq chassis

[shubav]

@wangxin @vmorokhx can this be reverted, please?

[vmorokhx]

I see no reason to revert, port_config.ini was deprecated, so we need this change. platform.json along with hwsku.json replace port_config.ini, and they must support multi ASIC platforms. If not, there should be a issue on this.

[rawal01]

config_facts ansible module gives port_index_map in each asic starting with index 0. Code from config_facts ansible module:

    if 'PORT' in config:
        port_name_list = config["PORT"].keys()
        port_name_list_sorted = natsorted(port_name_list)

        for idx, val in enumerate(port_name_list_sorted):
            port_index_map[val] = idx

So, it is not getting the 'port index' defined in platform.json / portconfig.ini, For example, for asic1 with starting port Ethernet18 (first port in the asic1), the port_index_map would be:

{
   Ethernet18: 0,
   Ethernet19: 1,
   .
   .
}

With the old method - this was:

{
   Ethernet18: 19,
   Ethernet19: 20,
   .
   .
}

So, using config_facts breaks this utility for multi-asic DUT.  We need to either resolve this, or revert the PR for now.

[shubav]

@arlakshm @rlhui can you please share how this is tested or planned to be tested for multi-asic platforms? Thanks.

[shubav]

@arlakshm we believe this breaks multi-asic tests. Could you please review and help get this reverted or propose how we can resolve this?