Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[voq] VoQ multiasic fixes and minigraph support #3752

Merged
merged 3 commits into from Jan 15, 2022

Conversation

mannytaheri
Copy link
Contributor

Description of PR

Summary:
updated VoQ test script to support configuration generated from minigraph.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • [x ] Test case(new/improvement)

Back port request

Approach

What is the motivation for this PR?

We are updating the VoQ test scripts to be in line with config generated in PR3746.

How did you do it?

Changed expected system port IDs to come from the generated metadata.
Adding support for loopback 4096 in IP forwarding test.
Adding support for the new internal BGP configuration (BGP_VOQ_CHASSIS_NEIGHBOR).
Minor fixes for muliasics tests.

How did you verify/test it?

Ran against muliascic VoQ chassis.

Any platform specific information?

No

Supported testbed topology if it's a new test case?

T2

Documentation

@mannytaheri mannytaheri requested a review from a team as a code owner July 8, 2021 22:08
@ghost
Copy link

ghost commented Jul 8, 2021

CLA assistant check
All CLA requirements met.

@shubav
Copy link
Contributor

shubav commented Jul 9, 2021

@saravanansv @yxieca is it possible to review these changes please? thanks.

@yxieca yxieca requested a review from arlakshm July 13, 2021 16:01
@anshuv-mfst anshuv-mfst requested a review from a team August 3, 2021 23:13
Copy link
Contributor

@arlakshm arlakshm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As comments

tests/common/helpers/redis.py Show resolved Hide resolved
tests/common/helpers/redis.py Show resolved Hide resolved
tests/voq/test_voq_ipfwd.py Show resolved Hide resolved
tests/voq/test_voq_ipfwd.py Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Nov 17, 2021

This pull request introduces 1 alert when merging 5433c43 into a82d09d - view on LGTM.com

new alerts:

  • 1 for Syntax error

harish-kalyanaraman pushed a commit to harish-kalyanaraman/sonic-mgmt that referenced this pull request Nov 18, 2021
harish-kalyanaraman pushed a commit to harish-kalyanaraman/sonic-mgmt that referenced this pull request Nov 18, 2021
harish-kalyanaraman pushed a commit to harish-kalyanaraman/sonic-mgmt that referenced this pull request Nov 18, 2021
tests/voq/voq_helpers.py Outdated Show resolved Hide resolved
@arlakshm arlakshm merged commit f8ee4c9 into sonic-net:master Jan 15, 2022
isabelmsft pushed a commit to isabelmsft/sonic-mgmt that referenced this pull request Feb 10, 2022
)

What is the motivation for this PR?
We are updating the VoQ test scripts to be in line with config generated in PR3746.

How did you do it?
Changed expected system port IDs to come from the generated metadata.
Adding support for loopback 4096 in IP forwarding test.
Adding support for the new internal BGP configuration (BGP_VOQ_CHASSIS_NEIGHBOR).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants