New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[voq] VoQ multiasic fixes and minigraph support #3752
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@saravanansv @yxieca is it possible to review these changes please? thanks. |
yxieca
reviewed
Jul 13, 2021
arlakshm
reviewed
Aug 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As comments
mannytaheri
force-pushed
the
voq_minigraph
branch
from
November 17, 2021 17:17
dbb25f0
to
5433c43
Compare
This pull request introduces 1 alert when merging 5433c43 into a82d09d - view on LGTM.com new alerts:
|
harish-kalyanaraman
pushed a commit
to harish-kalyanaraman/sonic-mgmt
that referenced
this pull request
Nov 18, 2021
…nytaheri:voq_minigraph)
harish-kalyanaraman
pushed a commit
to harish-kalyanaraman/sonic-mgmt
that referenced
this pull request
Nov 18, 2021
…d='my_lb_ip' (sonic-net#3752 - mannytaheri:voq_minigraph)
harish-kalyanaraman
pushed a commit
to harish-kalyanaraman/sonic-mgmt
that referenced
this pull request
Nov 18, 2021
arlakshm
reviewed
Dec 9, 2021
mannytaheri
force-pushed
the
voq_minigraph
branch
from
December 10, 2021 18:24
5433c43
to
97235ce
Compare
arlakshm
approved these changes
Jan 15, 2022
isabelmsft
pushed a commit
to isabelmsft/sonic-mgmt
that referenced
this pull request
Feb 10, 2022
) What is the motivation for this PR? We are updating the VoQ test scripts to be in line with config generated in PR3746. How did you do it? Changed expected system port IDs to come from the generated metadata. Adding support for loopback 4096 in IP forwarding test. Adding support for the new internal BGP configuration (BGP_VOQ_CHASSIS_NEIGHBOR).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
updated VoQ test script to support configuration generated from minigraph.
Type of change
Back port request
Approach
What is the motivation for this PR?
We are updating the VoQ test scripts to be in line with config generated in PR3746.
How did you do it?
Changed expected system port IDs to come from the generated metadata.
Adding support for loopback 4096 in IP forwarding test.
Adding support for the new internal BGP configuration (BGP_VOQ_CHASSIS_NEIGHBOR).
Minor fixes for muliasics tests.
How did you verify/test it?
Ran against muliascic VoQ chassis.
Any platform specific information?
No
Supported testbed topology if it's a new test case?
T2
Documentation